search

MediaArea / MediaConch

MediaConch (funded by PREFORMA)
31 stars 11 forks source link

No FFV1 implementation checks count in XML #198

Open kieranjol opened 7 years ago

kieranjol commented 7 years ago

I'm on Ubunutu 16.04 with the daily snapshot of mediaconch and libmediainfo. I only just noticed that while several Matroska implementation checks run in the GUI and CLI, no FFV1 checks run:

<implementationChecks checks_run="0" fail_count="0" pass_count="0">
      <name>MediaConch FFV1 Implementation Checker</name>

Here's an example file where this happens: https://drive.google.com/file/d/0ByvCvU9YVB09WTNSQ2ZEdXk2YXM/view?usp=sharing

I'm assuming that something is wrong with my command/environment?

kieranjol commented 7 years ago

And the full report, just in case: https://gist.github.com/kieranjol/9a5d18b0c38b501fe1d85811aab27371

dericed commented 7 years ago

hmmm, can you retry with --force

kieranjol commented 7 years ago

I used --force in my initial command line , I should have posted it: mediaconch --force -fx testplz.mkv

kieranjol commented 7 years ago

I replicated on Windows 10 with today's snapshot.

I think this could also be related, though it might be a seperate issue: mediaconch -mi filename returns nothing.I installed the latest libmediainfo as well on Win10 and Ubuntu,

JeromeMartinez commented 7 years ago

We use a different method for checking FFV1 bitstream because the one we use for MKV is too slow with so much data as it is in FFV1 (thousands of frames and we need to parse the whole frame content). As a result, the XML sees only fails for the moment.

We definitely need to change the output, showing also the count of succeeded tests instead of "0".

kieranjol commented 7 years ago

Hi Jerome, that would be ideal. My usage of Mediaconch involves looking at those summary judgements using an XML parser and determining if the validation=PASS/FAIL. It's good to know that fail_count=0 means that analysis was carried out, but it would be ideal to know that n checks were carried out and all passed, even if each one isn't documented in XML elements.

JeromeMartinez commented 7 years ago

ok. we need to do: