MediaArea / MediaConch

MediaConch (funded by PREFORMA)
29 stars 11 forks source link

Certain FFV1 decoding errors are not causing Implementation failures in MKV #234

Open iamdamosuzuki opened 9 months ago

iamdamosuzuki commented 9 months ago

I made a few test files using the bsf:v ffmpeg filter. I created a file with light corruption, medium corruption, and heavy corruption.

Of these three files, only the heavy corruption file triggers an implementation failure in either the GUI or CLI. However, all three files report some sort of decode error in ffmpeg. I tried using the -f and --full flags on the CLI but it didn't change anything.

Is this the expected behavior? Is there some way that MediaConch can fail these files with decode errors, even if they're minor?

The files can be found here

Here are the ffmpeg commands used to create the files:

ffmpeg -i FFV1.mkv -c copy -bsf:v noise=amount=-1 FFV1_HeavyCorruption.mkv

ffmpeg -i FFV1.mkv -c copy -bsf:v noise=amount='mod(n\,120)/110' FFV1_MediumCorruption.mkv

ffmpeg -i FFV1.mkv -c copy -bsf:v noise=amount='eq(n\,150)' FFV1_LightCorruption.mkv

JeromeMartinez commented 9 months ago

I tried using the -f and --full flags on the CLI but it didn't change anything.

I have made a mistake while talking with @dericed about full parsing, --full is for a full report, please try with --ParseSpeed=1 for parsing the whole file instead of only the beginning of the file.

iamdamosuzuki commented 9 months ago

Hi @JeromeMartinez , this worked! thanks for your help. Is it possible to add this flag to the help documentation?