search

MediaArea / MediaConch_SourceCode

Media conformance checker
https://MediaArea.net/MediaConch
BSD 2-Clause "Simplified" License
27 stars 17 forks source link

GUI/WUI: UX: Need for N/A results display #354

Open ablwr opened 8 years ago

ablwr commented 8 years ago

When MediaConch tries to parse a file, it is only checking for the existence of any errors. If none are found, it is considered valid. This is fine for the specifications that we have in MediaConch: Matroska and FFV1. However, this can easily give a "false positive" result for other formats. If there is no error but also all of the results are N/A, we should flag that as being N/A and have the results appear in yellow (not green or red).

tribouille commented 8 years ago

Long time discussion about the "N/A" as valid or not :)

ablwr commented 8 years ago

But did we have a externally-facing ticket? ;)

ablwr commented 8 years ago

I wonder if this may be resolved in some of @dericed upcoming display policy work.

tribouille commented 8 years ago

Hmmm, this one a little bit: https://github.com/MediaArea/MediaConch/issues/100

It will be resolved when Jerome and Dave will agree. It could be detected before... but it was chose to consider "N/A" as valid.

ablwr commented 8 years ago

Oh good point. We have a "too many repos" problem, Florent!

dericed commented 8 years ago

now that we can have an outcome at the top level of the xml, a pass, fail, or n/a can get to the top of the report. But is the UI ok to highlight the N/A result? At the Tate presenetation it seemed that reports with only "N/A" were highlighted as "OK". Can we have that third state in the UI?

beyo-ra commented 8 years ago

I think my comment concerns the same issue?

The main Results overview reports ”Valid” (Green with a checkmark) in the column ”Implementation” for files that are obviously not valid, such as .jar, .jpg, *.bin.

“View implementation report”, when expanded, manually or toggled verbosity, EBML Implementation Checker or FFV1 Implementation Checker do however correctly show Results N/A (Not recognized as.... ) Value: Undetermined

+1 The overview should not indicate the outcome with the same signal as a valid Implementation Check.

beyo-ra commented 8 years ago

I just ran a *.mkv test file using the CLI and received a n/a on IS_FFV1 (Not recognized as an FFV1 format but as AVC).

The same file in the GUI returned a green "Valid" in the column "Implementation". After rechecking the implementation report in the GUI, it had previously failed on the FFV1 check, but not on the Matroska check.

Perhaps splitting the implementation column in two sub columns (MKV | FFV) could be helpful? Which in this case would return GREEN/RED or GREEN/YELLOW depending on how you wish to signal n/a.

Currently the results seem to counter intuitive, or perhaps I am misunderstanding something?

tribouille commented 8 years ago

Just for information, N/A stand for "Not Applicable", not "Not recognized As". https://en.wikipedia.org/wiki/N/a

ablwr commented 8 years ago

Hi @beyo-ra, you are correct. We've had this conversation internally a few times about where to apply the change -- either deeper in the code, leave it as is, or just change the display to acknowledge presence of 100% N/A results in a test as flagged-in-yellow instead of green.