MediaArea / MediaConch_SourceCode

Media conformance checker
https://MediaArea.net/MediaConch
BSD 2-Clause "Simplified" License
29 stars 18 forks source link

Add error level to policy and rule elements #728

Closed g-maxime closed 2 years ago

g-maxime commented 2 years ago

Signed-off-by: Maxime Gervais gervais.maxime@gmail.com

JeromeMartinez commented 2 years ago

Great. I see very well the differences between pass/info/warn/error. At some point we may want to have an option for hiding info part (this would make the difference between info and warn in the CLI), but for the moment it is good enough.

> .\MediaConch.exe -p policy_pass_rule_pass.xml FileToTest
pass! FileToTest
> .\MediaConch.exe -p policy_pass_rule_info.xml FileToTest
pass! FileToTest
   --  [pass:Policy]
   --   [info:Rule]
> .\MediaConch.exe -p policy_pass_rule_warn.xml FileToTest
pass! FileToTest
   --  [pass:Policy]
   --   [warn:Rule]
> .\MediaConch.exe -p policy_pass_rule_fail.xml FileToTest
fail! FileToTest
   --  [fail:Policy]
   --   [fail:Rule]
> .\MediaConch.exe -p policy_warn_rule_warn.xml FileToTest
pass! FileToTest
   --  [pass:Policy]
   --   [warn:Rule]
> .\MediaConch.exe -p policy_warn_rule_fail.xml FileToTest
warn! FileToTest
   --  [warn:Policy]
   --   [fail:Rule]

Note: the level for policy may be hard to understand at the first try (the warning is raised if a rule in the policy fails) but the idea is good. We'll need some documentation at some point with such complex possibilities.

Close https://github.com/MediaArea/MediaConch_SourceCode/issues/727.