MediaArea / MediaInfo

Convenient unified display of the most relevant technical and tag data for video and audio files.
https://MediaArea.net/MediaInfo
BSD 2-Clause "Simplified" License
1.26k stars 149 forks source link

MediaInfo disables 'Enable FFmpeg plugin' in Windows #863

Closed passat1 closed 3 weeks ago

passat1 commented 3 weeks ago

In latest release (24.05.1) MediaInfo randomly disables 'Enable FFmpeg plugin' in 'Advanced' settings. After enabling it again it stays enabled for some time and then it just become disabled for no obvious reason. I notice that again if I open file which has black borders (up and down) but MediaInfo does not detect different 'Active height'. It is almost always after restarting system which is Windows 10 Enterprise 22H2 with all current updates.

MediaInfo_24 05 1

Also when I have opened such file, go to advanced settings, enable FFmpeg plugin and click 'OK', it opens file info again, but without that info about 'Active height'. So I have to close program and open file again to get it correct.

While writing this message, I opened advanced settings and it was disabled. I enabled it and twice open file with it, and it was enabled. Then after ending this message (after few minutes), I checked again, and it was disabled again. I'm always opening files with MediaInfo using Windows context menu. I can not trust what I see, so every time I open any file, I have to go to advanced settings to see if it's disabled again.

g-maxime commented 3 weeks ago

Is "Enable ffmpeg plugin" the only setting that gets randomly reset?

Does <User directory>/AppData/Roaming/MediaInfo/Plugin/MediaInfo.cfg contain EnableFfmpeg = 1 after the plugin gets disabled?

passat1 commented 3 weeks ago

For now it's the only setting I've noticed. I used MediaInfo at least 30 times today, and ffmpeg plugin gets disabled really randomly.

At this moment I checked and it is disabled again, and in mentioned file is EnableFfmpeg = 0. After I enabled it in settings and after program exit, value in file changed back to EnableFfmpeg = 1.

Then after opening 5-6 different files, it is disabled again and in file is again EnableFfmpeg = 0.

I noticed in that file that there is no value in line before that FFmpegPluginVersion =. Shouldn't there be something like '6.1' or similar? Because I installed version '6.1' and file Program Files\MediaInfo\Plugin\FFmpeg\version.txt contains text 6.1.

passat1 commented 3 weeks ago

I had installed 'K-Lite Codec Pack' 18.3.5 Mega on my system, which has included MPC-HC with 'mediainfo.dll' that is not using ffmpeg plugin. I was also checking properties with included MediaInfo while watching videos with MPC-HC. Yesterday late evening, I installed K-Lite update 18.3.6_20240604 which also updated 'mediainfo.dll'. Today I spent about an hour checking video files, with and without top/bottom borders. For now 'Enable FFmpeg plugin' was not disabled at all. Not only once. I will keep checking and report back at evening, or maybe tomorrow morning (CET) after new system boot.

JeromeMartinez commented 3 weeks ago

AFAIK the 2 DLL (ours in C:\Program Files\MediaInfo and MPC-HC in its directory) are very separate, weird.

But I reproduce the issue on my machine too, reproductible : launch, open preferences, activate FFmpeg, OK, open preferences, OK, open preferences, option is deactivated. Also with older versions so not a new issue from the developments in the latest version.

passat1 commented 3 weeks ago

Great, thanks for feedback. Now I know that is not something else in my system producing this problem, as I experiment a lot on it. Hope you will be able to solve problem soon. Good luck!

passat1 commented 3 weeks ago

I've found easier way to reproduce: Launch, open Preferences ('Setup' is shown) then select 'Advanced', activate FFmpeg and 'OK', select 'Setup', and back 'Advanced'. FFmpeg is disabled. Meaning, just going from 'Advanced' to 'Setup' and back to 'Advanced' (without any 'OK') is disabling FFmpeg.

g-maxime commented 3 weeks ago

Please test this snapshot

passat1 commented 3 weeks ago

Thanks. I did test snapshot and was not able to reproduce problem anyway anymore. But, if file is opened with disabled FFmpeg and then open settings and FFmpeg enabled, MediaInfo returns to main screen and displays file info. Displayed info is without 'Active height' and 'Active display aspect ratio', meaning FFmpeg is not used. Same is in situation if FFmpeg was active before and now is deactivated. Changes are not accepted on return to main screen from settings, and file is not analyzed again with new settings until file is not opened again.

JeromeMartinez commented 3 weeks ago

until file is not opened again.

We don't launch again the analysis automatically and we don't plan to change that for the moment (very corner case, and if someone want to implement and test no problem for accepting a patch).