MediaArea / MediaInfo

Convenient unified display of the most relevant technical and tag data for video and audio files.
https://MediaArea.net/MediaInfo
BSD 2-Clause "Simplified" License
1.31k stars 158 forks source link

24.06 - some pixels or cut off text and "moved" object in options dialog #889

Closed Klaus1189 closed 2 months ago

Klaus1189 commented 2 months ago

I just updated my MediaInfo installation (portable) to 24.06 and encountered some issues. But I don't know if these were already present in previous versions. I could check if you want me to.

Steps to reproduce unpack the portable archive and first start, the nyou will see the issue I captured with the screenshot: https://drive.google.com/file/d/1iR0_bAIL8KPLDwADK94USt4ubb6b8Q7H/view?usp=sharing

Please let me know if you need me to do anything else for you

cjee21 commented 2 months ago

24.05 Screenshot 2024-06-29 105502

24.06 Screenshot 2024-06-29 105543

The only change is added new setting as far as I know. The top "cut off text" is a high-DPI glitch that sometimes appear. Previously, something similar was noticed on the main window as well during testing.

Example on main window: Screenshot 2024-06-29 110529

cjee21 commented 2 months ago

@JeromeMartinez I suspect the glitch is due to these page tabs/selectors not hidden enough so the currently active one is slightly visible on very high DPI scaling sometimes.

Screenshot 2024-06-29 131429

Update: Found the lines of code responsible and think I have a fix.

JeromeMartinez commented 2 months ago

Still open due to image

@Klaus1189 correct me if I miss something.

Klaus1189 commented 2 months ago

Still open due to image

@Klaus1189 correct me if I miss something.

same for me in 200% and I set my monitor for testing to 100% and I can confirm @JeromeMartinez

cjee21 commented 2 months ago

Good news, I came across the solution to this while checking the other issue. Turns out the issue is at the tree view and not the sheet and it is really only off by a single pixel.

Is this good enough now? 100% 200%
Light Screenshot 2024-06-30 135808 Screenshot 2024-06-30 135857
Dark Screenshot 2024-06-30 135823 Screenshot 2024-06-30 135914
Klaus1189 commented 2 months ago

I like the dark ones, somehow the light versions look different from the dark ones, I mean a bit off. And the light 200% has a OK button which is cut off the rounded window. Strange Win11 The more I look I think the dark screenshots have another radius of the rounded corners. Best is a small testbuild if you don't mind.

cjee21 commented 2 months ago

Best is a small testbuild if you don't mind.

Testbuild need @JeromeMartinez I cannot upload my unsigned self-built version here without permission.

cjee21 commented 2 months ago

And the light 200% has a OK button which is cut off the rounded window.

Many buttons placed too close to the edges in my opinion. I added more margins to all elements in the about window but didn't change this.

JeromeMartinez commented 2 months ago

@cjee21 in your screenshots the dark them has alignment but the light theme has 1 bit diff, weird.

I added more margins to all elements in the about window but didn't change this.

I could be fine with that, I created that 20 years ago and didn't care so much about such details but if someones improves it I take it :).

cjee21 commented 2 months ago

I could be fine with that, I created that 20 years ago and didn't care so much about such details but if someones improves it I take it :).

Done.

JeromeMartinez commented 2 months ago

dev snapshot (before the margins).

Klaus1189 commented 2 months ago

dev snapshot (before the margins).

looks good to me, not perfect, but I would leave it like that. Just one last cosmetic change: Place the labels and the drop down lists on one height: last thing

Perhaps the two More buttons same height position and height size like the left of it. two more buttons Then I think it looks good.

JeromeMartinez commented 2 months ago

updated dev snapshot.

cjee21 commented 2 months ago

Perhaps the two More buttons same height position and height size like the left of it.

This is some DPI scaling issue. It is exact same height/position on 100%. Same as the button next to filename selector on main window.

JeromeMartinez commented 2 months ago

Good enough for the moment, I merge and if someone is motivated for checking this 200% DPI issue I would be happy to get the patch else it will stay as is.

Klaus1189 commented 2 months ago

updated dev snapshot.

Looks good to me on 200%