24.06 - Open Preferences and click on "Adavanced" -> GUI buttons appear

[Klaus1189]

Open MediaInfo Open "Preferences" and click on "Advanced" then despite search is disabled and version is up to date buttons appear:

And despite "toolbar" is disabled after closing the "Preferences" the toolbar is not hidden, only the buttons disappear but the place stays like it is still shown, but on only a cut off non-working orange button is shown is this area:

[cjee21]

There's another minor 'Preferences' window bug I found. When clicking 'More...' next to 'Language' on 'Setup' page, it goes to 'Customize' -> 'Graph'. I'm guessing it should be going to 'Customize' -> 'Language'.

Update: This one fixed by me.

[cjee21]

And despite "toolbar" is disabled after closing the "Preferences" the toolbar is not hidden, only the buttons disappear but the place stays like it is still shown, but on only a cut off non-working orange button is shown is this area: https://drive.google.com/file/d/1AamHX_5Ql0HlsKfBwImyLM35kywfcHOE/view?usp=sharing

Steps to reproduce

1. Open 'Preferences' -> 'Advanced'
2. Disable 'Show toolbar' and click 'OK'
3. Do step 1 again
4. Click 'OK' without touching anything else

[Klaus1189]

If you need anything in this issue, please let me know. Testing or anything, I do it for you.

And translation later, it will take some time. For RTSS and MSI Afterburner I also needed some time for full new translation: https://forums.guru3d.com/threads/german-translation.447957/

[cjee21]

I wonder why many things seem to happen on the main window upon clicking advanced in preferences window. I don't see anything that may cause that in this function: https://github.com/MediaArea/MediaInfo/blob/dda61d6a99aa58fbf69b488669c2ac26242222b2/Source/GUI/VCL/GUI_Preferences.cpp#L629

[cjee21]

Debugging results:

Open MediaInfo Open "Preferences" and click on "Advanced" then despite search is disabled and version is up to date buttons appear:

When Advanced is clicked in Preferences, the Setup_AdvancedShow mentioned above is called. Then when this line is executed, https://github.com/MediaArea/MediaInfo/blob/223d9ae5844bc369545a9ef04c2b93847e6ce641/Source/GUI/VCL/GUI_Preferences.cpp#L632 what you see in the above screenshot appears (it is greyed out on standard theme, indicating that no new version is actually available). So it seems to be triggered by something in Prefs? In that case I will not be digging further. I took a look at Prefs area before to figure out how language files get duplicated but gave up. @JeromeMartinez should assign someone else.

[JeromeMartinez]

@JeromeMartinez should assign someone else.

for me.

[cjee21]

So it seems to be triggered by something in Prefs?

@JeromeMartinez Upon further testing, it appears to not be caused by Prefs.

I changed

https://github.com/MediaArea/MediaInfo/blob/223d9ae5844bc369545a9ef04c2b93847e6ce641/Source/GUI/VCL/GUI_Preferences.cpp#L632

to

CB_ShowMenu->Checked=1;

and it still happens. It won't let me step into this line so I cannot check further.

[cjee21]

@JeromeMartinez While looking around for something else, found the cause of the orange button partially visible in 2nd screenshot of first post...

This is hiding behind there (a second, unnamed 'Donate' button?):

[JeromeMartinez]

This is hiding behind there (a second, unnamed 'Donate' button?):

It is from a very old code with buttons for donation, actually they should be deleted now. Need to take time for big cleanup of that.

[cjee21]

This is hiding behind there (a second, unnamed 'Donate' button?):

It is from a very old code with buttons for donation, actually they should be deleted now. Need to take time for big cleanup of that.

I helped removed the donate buttons and their related codes. Also done some clean-up and re-organization of codes.

Partially fixed this issue also. Now the GUI is properly displayed after Preferences window is closed. However, when Preferences->Advanced is open, the issue mentioned is still there including the toolbar being displayed even when unchecked.