search

MediaArea / MediaInfo

Convenient unified display of the most relevant technical and tag data for video and audio files.
https://MediaArea.net/MediaInfo
BSD 2-Clause "Simplified" License
1.31k stars 158 forks source link

Character police issue #893

Closed JeromeMartinez closed 2 months ago

JeromeMartinez commented 2 months ago

(Received by email)

I have used Mediainfo for a number of years and I find it very useful. I just updated to Mediainfo for Windows 24.06 but I find the text output is much lighter and thinner, I prefer the bolder text of the previous version I had which was 24.01.1 I reinstall the previous version and the bold and darker text returned, is this a deliberate lightening of the text output? How do I get the bolder and darker text display with your new version? if I cannot I will just stick to 24.06 and disable the check for update function.

cc @cjee21 for comment.

cjee21 commented 2 months ago

Possibilities:

  1. Use bold version of Cascadia Mono.
  2. Add font selection so users can choose any font they like (harder to implement).

Whatever font is chosen, I guess cannot satisfy everyone. So number 2 is the only way to satisfy everyone.

JeromeMartinez commented 2 months ago

So number 2 is the only way to satisfy everyone.

I am fine with your update so I guess that it is the only way (reason MI command line has so many options...). As well as font size, criticized in the past.

No pressure as it is on your free time but if you are interested in coding that (font name, bold, size), we are interested ;-).

cjee21 commented 2 months ago

No pressure as it is on your free time but if you are interested in coding that (font name, bold, size), we are interested ;-).

Right now my priority is on 64-bits and Windows 11 context menu to be honest. Those are what actually matters for my use. The other parts are almost perfect already for me.

By the way, I have been using MediaInfo for years (can't remember when started). Thank you for this one-and-only app that enables me to view insights of media files, learn more about various codecs and check that my files have the correct streams, codecs, metadata etc. Glad that I can contribute to it.

cjee21 commented 2 months ago

Bold font test: Screenshot 2024-06-30 114925

@JeromeMartinez let you decide whether to use bold or no bold. Cascadia Mono actually has many font weights but VCL seems to only be bold or no bold with no in-between.

cjee21 commented 2 months ago

If increase font size instead: Screenshot 2024-06-30 123735

JeromeMartinez commented 2 months ago

Increase of police size as an impact of having less content displayed, doesn't seem to be the case with bold. I am checking before/after the change, looks like that bold could be a good intermediate, changing the font for a more clear one but using bold for something more similar to the past, for the default (and only one until we implement font choice).

@cjee21 are you fine with bold?

cjee21 commented 2 months ago

@cjee21 are you fine with bold?

Still better than the old jagged edges font I guess.

JeromeMartinez commented 2 months ago

Still better than the old jagged edges font I guess.

Would you mind to do a PR?

cjee21 commented 2 months ago

@JeromeMartinez I managed to use the semi bold variant of Cascadia Mono (required the exact correct name)

Screenshot 2024-07-01 160732

I think this one looks the best for MediaInfo compared to regular and bold. What do you think? Another PR?

JeromeMartinez commented 2 months ago

I think this one looks the best for MediaInfo compared to regular and bold. What do you think? Another PR?

Yes, please. By the way, the bold and semi-bold seem to show a bigger issue about the lack of space between the characters and the left toolbar, could you add some margin there while you are on that?

cjee21 commented 2 months ago

could you add some margin there while you are on that?

Sure, just need to enable auto margins. How about the background colour? That is changeable too.

JeromeMartinez commented 2 months ago

How about the background colour? That is changeable too.

I have no strong preference there, little preference for not changing all.

cjee21 commented 2 months ago

Just testing. This is how it looks on white.

Screenshot 2024-07-01 162222

JeromeMartinez commented 2 months ago

Just testing. This is how it looks on white.

Let's try that.

cjee21 commented 2 months ago

By the way, are the text in all the views supposed to be editable? Just discovered that they are editable.

JeromeMartinez commented 2 months ago

By the way, are the text in all the views supposed to be editable?

Not really :). but important that they can be copied/pasted, IIRC (it was a very long time ago) I changed that for being copied/pasted.

cjee21 commented 2 months ago

By the way, are the text in all the views supposed to be editable?

Not really :). but important that they can be copied/pasted, IIRC (it was a very long time ago) I changed that for being copied/pasted.

Read-only mode is still copy-able :)