Text view changes for Windows and Qt GUI

MediaArea / MediaInfo

Convenient unified display of the most relevant technical and tag data for video and audio files.

https://MediaArea.net/MediaInfo

BSD 2-Clause "Simplified" License

1.4k stars 160 forks source link

Text view changes for Windows and Qt GUI #946

Closed cjee21 closed 2 weeks ago

cjee21 commented 2 weeks ago

Make VCL GUI Text views editable again due to requests
Make Qt GUI Text view editable to match VCL GUI behaviour
Reduce brightness of Text and Tree views in VCL GUI light mode to exactly match the brightness of Easy view and also other Windows apps such as Notepad.

Fix https://github.com/MediaArea/MediaInfo/pull/944#issuecomment-2465416491

JeromeMartinez commented 2 weeks ago

Looks like that a mistake (having the text output editable) is actually a wanted feature, could you bring back the editable text view?

Received by email:

The latest update is useless when the edit / Select all not working!

Ctrl+A: Not working! Edit: If I wanna delete the path folder can't do anymore! It was good before this update!

I hope you guys let us control back! Instead of copy paste into Notepad to do that!

cjee21 commented 2 weeks ago

Looks like that a mistake (having the text output editable) is actually a wanted feature, could you bring back the editable text view?

I'll force push this and rename when done.

FYI the wxwidgets (tested on Ubuntu) and Qt (tested on Windows) ones are not editable.

JeromeMartinez commented 2 weeks ago

FYI the wxwidgets (tested on Ubuntu) and Qt (tested on Windows) ones are not editable.

There are 100x more users on Windows and then 100x more user feedback/complains on it :-p. (could also be done on Wx & Qt but not a priority for me, priority is to avoid receiving too many emails from Windows users)

cjee21 commented 2 weeks ago

Edit: If I wanna delete the path folder can't do anymore! It was good before this update!

I hope you guys let us control back! Instead of copy paste into Notepad to do that!

By the way, if they are going to copy paste it somewhere anyway, why do they need to edit in MediaInfo? Won't they be able to edit it wherever they paste it anyway? It is not possible to save or print the edited version from MediaInfo so they have to copy paste it somewhere anyway so why not edit after pasting? the only possibility that editing in MediaInfo opens up is creating fake screenshots that does not represent actual MediaInfo output isn't it?

JeromeMartinez commented 2 weeks ago

if they [...]

A rule for developers of widespread software: don't try to understand all of them, you will become crazy before you understand.

JeromeMartinez commented 2 weeks ago

snapshot (before brightness).

cjee21 commented 2 weeks ago

@JeromeMartinez side note:

Actually I wanted to make MediaInfo dark mode look nicer with native title bar and window shadows like below:

Dark mode concept test 2024-11-10 165756

However some issues regarding VCL styles and MainMenu prevents this from being a success. If a different bar that is not TMainMenu is used for menu bar, it will be easy but migrating the menu bar seems too much work.

JeromeMartinez commented 2 weeks ago

it will be easy but migrating the menu bar seems too much work.

It is nice from you to try, but on our side we won't change that because we need to focus on format support and we don't want to refactor everything now (as you can see, any change in the UI creates a lot of feedback...).

The UI you created is already very nice (based on from where it comes from, without changing the basics) by having high DPI and Dark Theme as it is!