search

MediaArea / MediaInfo

Convenient unified display of the most relevant technical and tag data for video and audio files.
https://MediaArea.net/MediaInfo
BSD 2-Clause "Simplified" License
1.4k stars 160 forks source link

Update file extensions lists #967

Closed cjee21 closed 1 week ago

JeromeMartinez commented 1 week ago

I saw https://github.com/MediaArea/MediaInfo/pull/960#issuecomment-2481973220 too late. Lists should be same everywhere.

cjee21 commented 1 week ago

I saw #960 (comment) too late. Lists should be same everywhere.

I will try to see if I can come up with a way to auto generate all the lists from a single list. To ensure all are the same and make it easier to edit the lists next time.

JeromeMartinez commented 1 week ago

I will try to see if I can come up with a way to auto generate all the lists from a single list.

Would be nice.

cjee21 commented 1 week ago

@JeromeMartinez Need to do something about the audio video thing.

In installer there is: !insertmacro MediaInfo_Extensions_Uninstall_I "audio" !insertmacro MediaInfo_Extensions_Uninstall_I "Folder" !insertmacro MediaInfo_Extensions_Uninstall_I "video"

In Preferences.cpp there is: ExplorerShell_Edit("Software\Classes\Directory", Config.Read(__T("ShellExtension_Folder")).To_int32s(), IsChanged);

So Folder and Directory is mismatch as well as Preferences.cpp list no audio and video. Also, the Preferences.cpp code is not correctly removing the audio and video entries added by installer when user chooses to disable the shell extension.

cjee21 commented 1 week ago

Done matching all except Source\GUI\Cocoa\MediaInfo-Info.plist since the list is split in there so I do not know what goes where and what is missing.

Here is the spreadsheet that can auto-generate the lists: MediaInfo_fileextensions.xlsx

JeromeMartinez commented 1 week ago

So Folder and Directory is mismatch as well as Preferences.cpp list no audio and video. Also, the Preferences.cpp code is not correctly removing the audio and video entries added by installer when user chooses to disable the shell extension.

Oops... If I understand correctly this post, I should uninstall "Folder" and install "Directory", and let the CPP as is.

JeromeMartinez commented 1 week ago

So Folder and Directory is mismatch as well as Preferences.cpp list no audio and video. Also, the Preferences.cpp code is not correctly removing the audio and video entries added by installer when user chooses to disable the shell extension.

I should read all notifications before answering, now seeing https://github.com/MediaArea/MediaInfo/pull/968, thanks!