MediaArea / MediaInfoLib

Convenient unified display of the most relevant technical and tag data for video and audio files.
https://mediaarea.net/MediaInfo
BSD 2-Clause "Simplified" License
628 stars 170 forks source link

Channels not detected in MPEG-TS #537

Open Sami32 opened 7 years ago

Sami32 commented 7 years ago

As it's a "living" format, i think it deserve it's own issue ?

with Opus audio: opus.ts.txt

Note: The good thing, is that it's make me aware of one flaw in my code concerning MPEG-TS channels parsing ;-)

JeromeMartinez commented 7 years ago

Opus is not supported by MediaInfo, and TS does not have any generic channel count info.

Sami32 commented 7 years ago

I'm not sure to follow you. As i didn't have any other Opus sample, i downloaded one to test (in an OGG container)

Audio
ID                                       : 14772 (0x39B4)
Format                                   : Opus
Duration                                 : 37 s 576 ms
Channel(s)                               : 2 channels
Channel positions                        : Front: L R
Sampling rate                            : 44.1 kHz
Compression mode                         : Lossy
Writing library                          : libopus 1.1.x-git

So, it seem that some support is in MediaInfo ?

TS does not have any generic channel count info.

Do that mean that i can close that issue, as it's not possible or imply a full parsing of the file ?

JeromeMartinez commented 7 years ago

So, it seem that some support is in MediaInfo ?

As you said, this is OGG. OGG contains metadata about channel count. Not TS. So when the stream format is not supported, metadata is retrieved from the container and it works well for OGG (metadata is there), not TS (metadata is not there).

Do that mean that i can close that issue

No, just need someone interested in either developing the support or paying someone interested in being paid for developing.

or imply a full parsing ?

No, just the Opus header (I started to read the spec some time ago, not really complex, just no time on my side for doing it on free support, paid support is already complaining a bit about delays in my response time).

JeromeMartinez commented 7 years ago

Do that mean that i can close that issue

Issue is real, so it should be let open. I flagged it as "NeedSponsor" for 2 reasons:

Sami32 commented 7 years ago

Thank you for clarifying things.

I can understand you, to much things to do, and a not stretching time :wink:

Aleksoid1978 commented 7 years ago

MPEG-TS have metadata for Opus streams. It's store in PMT, in DVB extension descriptor(0x7F). Here is documentation - https://wiki.xiph.org/OpusTS

JeromeMartinez commented 7 years ago

I was willing to say that there is no generic metadata, so development is needed for each format, also for the descriptor (specific to Opus) Thanks for the link, it will used when someone codes Opus/TS support.