search

MediaArea / MediaInfoLib

Convenient unified display of the most relevant technical and tag data for video and audio files.
https://mediaarea.net/MediaInfo
BSD 2-Clause "Simplified" License
628 stars 170 forks source link

SubRip_str2timecode == Ttml_str2timecode #741

Open pavel-pimenov opened 6 years ago

pavel-pimenov commented 6 years ago

Source\MediaInfo\Text\File_SubRip.cpp(39):int64u SubRip_str2timecode(const char Value) Source\MediaInfo\Text\File_Ttml.cpp(42):int64u Ttml_str2timecode(const char Value)

default

JeromeMartinez commented 6 years ago

Something for new TimeCode class, I guess.

pavel-pimenov commented 6 years ago

Add static member function
int64u TimeCode::str2timecode(const char* Value) { ... and PR?

JeromeMartinez commented 6 years ago

hum, now hesitating, having double-checked I see it is a timestamp (not a timecode), as the part after seconds are milliseconds. But most code is similar between timecode and timestamp.

I have some ideas for having something handling both timestamps and timecodes, including handling of Scc_str2timecode which is similar, I take it.