MediaArea / MediaInfoLib

Convenient unified display of the most relevant technical and tag data for video and audio files.
https://mediaarea.net/MediaInfo
BSD 2-Clause "Simplified" License
630 stars 170 forks source link

Size of attachments ignored in Matroska Bit rate/Stream size calculations #876

Open mkver opened 6 years ago

mkver commented 6 years ago

In the absence of Matroska tags containing information about stream size etc. MediaInfo can come to really bad estimates regarding stream size/bit rate. Here is an example: A file which contains an attachment which takes up most of the filesize (a bit less than 90%). I know that MediaInfo's numbers won't ever be reliable in 100% of all cases, but given that it already parses the attachment element and reports about it, it might be smart enough to take the attachment size in account when estimating bit rate and stream size.

JeromeMartinez commented 6 years ago

it is a corner case, but true that it is easy to subtract attachments file size.

dericed commented 6 years ago

+1. For the mkv files generated by qctools (thumbnails + attachment of gzipped xml), the attachment is ~20% of the space, so the stream sizes are quite off.