search

MediaBrain-SJTU / Where2comm

141 stars 13 forks source link

A question about the implementation of communication mask generation. #4

Open Little-Podi opened 1 year ago

Little-Podi commented 1 year ago

Happy rabbit year! Can you please explain why we need reset the communication mask to ones with a stride of 2 in the following line (https://github.com/MediaBrain-SJTU/Where2comm/blob/5ea31dcc4e102fc45a3dfcc5bff0339ee06543ac/opencood/models/comm_modules/where2comm.py#L71)? I cannot find anything related to this part in your paper, and I think it will be very helpful for us!

sidiangongyuan commented 1 year ago

Did you find anything about the request map in the code? I don't understand how the request map is generated.

Little-Podi commented 1 year ago

The public code is not perfectly organized with several missing parts, but it should be easy to reproduce their reported performance even you directly ignore and bypass those uncompleted implementations. The overall code framework is clear to handle.

fengxueguiren commented 5 months ago

根据我调试代码的理解，这个行代码的意思是设置ego车辆的mask为1，其他的值不变，也就是说ego不需要考虑通讯问题。