Standardize logging and new options

MediaBrowser / Emby.AutoOrganize

Auto-organize plugin for Emby Server

MIT License

21 stars 18 forks source link

Standardize logging and new options #38

Open kingy444 opened 3 years ago

kingy444 commented 3 years ago

A few things have been included:

Standardize Error Logging Error logging now prevents unneeded 500 errors and restores errors to the front user interface (in a user readable way) instead of presenting blank 'Internal Server Error'
fix throbber.gif Throbber.gif was removed from the core and has been throwing 404 unavailable in the console. moved to mdl-spinner in line with main loader (with some inline styles to make it work)
Fix handling of files when using different extensions Previous behavior resulted in file of different extensions being possible (avi,mkv,mp4 etc) This is still possible, but options are added to also prevent it from occurring
Allow TBA option added This option will prevent sorting of episodes until metadata for the episode is available A good addition here would be being able to call 'update metadata' for that episode at the time of failure but i am not sure how to add that
Created a new thumb to match other plugins and look a bit more professional

LukePulverenti commented 3 years ago

Can you embed it's own private spinner that doesn't depend on the core one? This will just break again if I ever make changes to the built-in one.

kingy444 commented 3 years ago

Can you embed it's own private spinner that doesn't depend on the core one? This will just break again if I ever make changes to the built-in one.

Yea - I’ll make that next priority - you happy to accept the throbber fix as is for now and I’ll include the change in the next release?

Any assistance on forcing a metadata refresh for a particular item based on targetPath would be awesome too to go with the TBA episode setting

LukePulverenti commented 3 years ago

A force metadata refresh is not needed. The plugin already notifies the server core when it does any file operations.

kingy444 commented 3 years ago

A force metadata refresh is not needed. The plugin already notifies the server core when it does any file operations.

Sorry I might not be being clear.

When the file is organised successfully I get the server refreshes etc.

the ‘allow TBA’ prevents a episode being sorted until an episode title is provided (other than TBA) so it would be useful for the plugin to force a metadata refresh for that one episode to prevent files sitting there too long.

Is the call to fetch the episode name live to thetvdb etc or utilising a cache ? I was assuming the latter so hence requesting the refresh.

Personally I have the ‘include metadata for missing episodes’ enabled so not sure if that might effect the outcome here either

kingy444 commented 2 years ago

@LukePulverenti was there anything left to do on this commit ? I have been offline on this one for some time but getting back to it now and actually thought this commit was merged.

Did you want any more changes ? If this is ok to go i can work on trying to merge the work chef has done into core