MediaBrowser / Emby.Common

3 stars 5 forks source link

This is not the source of the included DLLs in Emby #2

Closed berrnd closed 6 years ago

berrnd commented 6 years ago

This repository can be in fact not the source of the included DLLs in Emby.

First example: The MediaBrowser.Model project does not even compile properly in the current state:

1>------ Rebuild All started: Project: MediaBrowser.Model, Configuration: Debug Any CPU ------
1>CSC : error CS2001: Source file 'C:\Temp\Emby.Common\MediaBrowser.Model\Properties\AssemblyInfo.cs' could not be found.
========== Rebuild All: 0 succeeded, 1 failed, 0 skipped ==========

Second example: Here is a property User of class AuthorizationInfo referenced which is itself defined here and has no property User in the currently committed version.

Please clarify this.

I find it really strange to move parts in a separate repository and include them as compiled blobs in the main project, especially when they are not the same afterwards. Is there something you want to hide? Or why is this such a fuckup with all the recent and ongoing remarks about the "being Open Source" problems? I understand that maybe it's better to move parts to a separate repository for organization purposes, but why not just include them as GIT submodules or something in the main project instead of compiled blobs? I did this here, works great, when this source here would compile properly...

I want to reference the following related issues: MediaBrowser/Emby.Common#1 MediaBrowser/Emby#3075 MediaBrowser/Emby#3376

LukePulverenti commented 6 years ago

Sorry I had not finished updating it yet. It should be good now. Thanks.

berrnd commented 6 years ago

Thanks - and sorry for maybe being too offensive, it just looked a little odd in relation to the referenced issues...