MediaBrowser / Emby

Emby Server is a personal media server with apps on just about every device.
https://emby.media
GNU General Public License v2.0
4.09k stars 798 forks source link

Crew before cast in dash #194

Closed tikuf closed 11 years ago

tikuf commented 11 years ago

Currently the crew shows before the cast in the dash. As we are more likely to have images for the cast than the crew and the cast is more likely to be used (imho) it may look a bit better if they were switched around. (or there were 2 sections with cast expanded and crew compressed)

LukePulverenti commented 11 years ago

please post a screenshot.

On Wed, Apr 24, 2013 at 9:16 PM, Simon notifications@github.com wrote:

Currently the crew shows before the cast in the dash. As we are more likely to have images for the cast than the crew and the cast is more likely to be used (imho) it may look a bit better if they were switched around. (or there were 2 sections with cast expanded and crew compressed)

— Reply to this email directly or view it on GitHubhttps://github.com/MediaBrowser/MediaBrowser/issues/194 .

Luke Pulverenti

tikuf commented 11 years ago

crew-cast

LukePulverenti commented 11 years ago

Use the library explorer and find the PersonType of those actors.

On Wed, Apr 24, 2013 at 9:22 PM, Simon notifications@github.com wrote:

[image: crew-cast]https://f.cloud.github.com/assets/3683922/423115/7fd8a084-ad46-11e2-90de-e2197bf5041f.jpg

— Reply to this email directly or view it on GitHubhttps://github.com/MediaBrowser/MediaBrowser/issues/194#issuecomment-16983234 .

Luke Pulverenti

tikuf commented 11 years ago

Its not on all movies just some not sure if its my xml or not

LukePulverenti commented 11 years ago

Probably your xml find out in the library explorer.

On Wed, Apr 24, 2013 at 9:25 PM, Simon notifications@github.com wrote:

Its not on all movies just some not sure if its my xml or not

— Reply to this email directly or view it on GitHubhttps://github.com/MediaBrowser/MediaBrowser/issues/194#issuecomment-16983540 .

Luke Pulverenti

tikuf commented 11 years ago
"People": [
    {
        "Name": "Danny Elfman",
        "Role": "",
        "Type": "Original Music Composer"
    },
    {
        "Name": "Jim Lemley",
        "Role": "",
        "Type": "Producer"
    },
    {
        "Name": "Pamela Pettler",
        "Role": "",
        "Type": "Screenplay"
    },
    {
        "Name": "Тимур Бекмамбетов",
        "Role": "",
        "Type": "Producer"
    },
    {
        "Name": "Tim Burton",
        "Role": "",
        "Type": "Producer"
    },
    {
        "Name": "Dana Ginsburg",
        "Role": "",
        "Type": "Producer"
    },
    {
        "Name": "Mary Clayton",
        "Role": "",
        "Type": "Producer"
    },
    {
        "Name": "Jinko Gotoh",
        "Role": "",
        "Type": "Producer"
    },
    {
        "Name": "Shane Acker",
        "Role": "",
        "Type": "Screenplay"
    },
    {
        "Name": "Marci Levine",
        "Role": "",
        "Type": "Producer"
    },
    {
        "Name": "Nick Kenway",
        "Role": "",
        "Type": "Editor"
    },
    {
        "Name": "Mindy Marin",
        "Role": "",
        "Type": "Casting"
    },
    {
        "Name": "Robert St. Pierre",
        "Role": "",
        "Type": "Production Design"
    },
    {
        "Name": "Fred Warter",
        "Role": "",
        "Type": "Production Design"
    },
    {
        "Name": "Christophe Vacher",
        "Role": "",
        "Type": "Art Direction"
    },
    {
        "Name": "Giles Keyte",
        "Role": "",
        "Type": "Still Photographer"
    },
    {
        "Name": "Shane Acker",
        "Role": "",
        "Type": "Director"
    },
    {
        "Name": "Elijah Wood",
        "Role": "9 (voice)",
        "Type": "Actor"
    },
    {
        "Name": "John C. Reilly",
        "Role": "5 (voice)",
        "Type": "Actor"
    },
    {
        "Name": "Jennifer Connelly",
        "Role": "7 (voice)",
        "Type": "Actor"
    },
    {
        "Name": "Christopher Plummer",
        "Role": "1 (voice)",
        "Type": "Actor"
    },
    {
        "Name": "Crispin Glover",
        "Role": "6 (voice)",
        "Type": "Actor"
    },
    {
        "Name": "Martin Landau",
        "Role": "2 (voice)",
        "Type": "Actor"
    },
    {
        "Name": "Fred Tatasciore",
        "Role": "8 (voice)",
        "Type": "Actor"
    },
    {
        "Name": "Tom Kane",
        "Role": "Dictator (voice)",
        "Type": "Actor"
    },
    {
        "Name": "Alan Oppenheimer",
        "Role": "Scientist (voice)",
        "Type": "Actor"
    },
    {
        "Name": "Helen Wilson",
        "Role": "Newscaster (voice)",
        "Type": "Actor"
    },
    {
        "Name": "Pamela Pettler",
        "Role": "",
        "Type": "Writer"
    },
    {
        "Name": "Shane Acker",
        "Role": "",
        "Type": "Writer"
    }
tikuf commented 11 years ago

It appears in the dash in the same order that it appears in the xml.

ebr11 commented 11 years ago

Okay, ignore this post but I'm loving that shot of Jennifer Connelly. Looks like it was taken before she got skinny and lost her chest ;).

RedshirtMB commented 11 years ago

Haha.It's a nice shot.

Looking at the screenshot Tikuf provided, It would be nice if roles were combined. So show Shane Acker once, but have his role be Screenplay / Director rather than showing him twice.