search

MediaBrowser / Emby

Emby Server is a personal media server with apps on just about every device.
https://emby.media
GNU General Public License v2.0
4.14k stars 805 forks source link

Rename "Season 0" to "Specials"? #289

Closed ebr11 closed 11 years ago

ebr11 commented 11 years ago

Should we do this internally or force people to physically re-name their folders?

LukePulverenti commented 11 years ago

Internally, when it's resolved, although it goes back to clearing meta values which i don't think we should do. i think that could cause it to get lost, and it seems overkill to write a provider for this.

On Sat, May 18, 2013 at 11:30 AM, Eric Reed notifications@github.comwrote:

Should we do this internally or force people to physically re-name their folders?

— Reply to this email directly or view it on GitHubhttps://github.com/MediaBrowser/MediaBrowser/issues/289 .

Luke Pulverenti

LukePulverenti commented 11 years ago

But even this approach is heavy, because if we want to make it configurable, a change requires a library rebuild.

ebr11 commented 11 years ago

If we never clear metadata values, how do we ever delete data? This is the only reason I put that logic in. If you deleted something or an item was mis-identified the first time, it was impossible to get rid of the data.

ebr11 commented 11 years ago

Will having the user re-name their TV specials folder to "Specials" work? If so, I think that might be the best answer for this particular issue.

LukePulverenti commented 11 years ago

It just seems to add to the whole black box. If we mis-identify something, we currently don't offer any tools to help re-identify. we generally tell them to rename the folder and that causes a new item anyway. if we could remove this, it would make the metadata editing a lot easier to build, and then that could be used as a tool to correct something and re-fetch. if you want the fetchers to be a competitive alternative to standalone programs. then the decision making has to come out of low level code and moved up to where it is user controlled.

On Sat, May 18, 2013 at 1:09 PM, Eric Reed notifications@github.com wrote:

If we never clear metadata values, how do we ever delete data? This is the only reason I put that logic in. If you deleted something or an item was mis-identified the first time, it was impossible to get rid of the data.

— Reply to this email directly or view it on GitHubhttps://github.com/MediaBrowser/MediaBrowser/issues/289#issuecomment-18104559 .

Luke Pulverenti

ebr11 commented 11 years ago

But how does that solve the issue at hand - of removing data that needs to be removed?

Also, for metadata editing we are going to have to manipulate and save the same files that the 3rd party guys do. Otherwise, our edits will never persist any kind of re-scan. So, for that, this doesn't really appear to be an issue.

LukePulverenti commented 11 years ago

You're right, the edits have to be saved elsewhere but if it weren't for this, at least the work could be broken down into two separate stages. Now it all has to be done together which means it could be a while before we see the feature.

As far as removing data, I don't think we need to be smart about that. Metabrowser doesn't do that at all. If it mis-identifies something, generally the first thing I'll do is make sure the file/folder name matches tmdb/tvdb exactly. If that's the case and it's still wrong, I find the tmdb id myself, punch it in, tell it to re-fetch that one item, and it works perfectly.

ebr11 commented 11 years ago

Where I ran into the issue was with images. Let's say the wrong logo.png got put in a folder so I deleted it. The library still showed it and always would until you deleted the db file.

Unless we provide the ability to clear out these values then some provider has to "own" each piece of metadata so that it can do it.

LukePulverenti commented 11 years ago

That's definitely a bug if that's still the case. I'm guessing possibly not anymore with the introduction of the file system stamp. I will just say this. I understand these providers better than anyone aside from you, and yet I'm still often confused at all the different conditions and checks. The only way to make the support questions go away about why things aren't getting refreshed is to take the decision making out of the code and push it up to the dashboard, such as the way scheduled tasks are fully controllable. (Imagine if each task decided it's own schedule as well as whether or not it wanted to run each time).

ebr11 commented 11 years ago

It's not the case anymore because we clear out the image paths before allowing the providers to run. If you can find some other way of accomplishing that, I'm fine with it. I just don't know how we erase something without either having the baseitem do it before a refresh or having a provider own a particular attribute and do it itself.

LukePulverenti commented 11 years ago

Actually the remote season provider is already doing this, so we could just leave it at that..

        if (seasonNumber == 0)
        {
            season.Name = "Specials";
        }
ebr11 commented 11 years ago

I think we should have people rename their season 0 folders and be consistent now that we can have specials anywhere. That appears to work.

The rename internally is also okay but I don't think it works in all instances (maybe without inet providers?)

LukePulverenti commented 11 years ago

The internal rename will only work with internet providers, yes. I keep going through many different scenarios, but I think I'm back to my first one, which is doing it at resolve time.

ebr11 commented 11 years ago

That is when it is done in MB2.

gcw07 commented 11 years ago

This doesn't seem to be working at the moment. My Season 0 is still showing as Season 0 instead of Specials.

LukePulverenti commented 11 years ago

If you haven't rebuilt your library since the setting was introduced, you'll need to do that. It's a one time thing. From there on out, you can change the setting on the fly.

On Mon, Jun 10, 2013 at 2:52 PM, Grant notifications@github.com wrote:

This doesn't seem to be working at the moment. My Season 0 is still showing as Season 0 instead of Specials.

— Reply to this email directly or view it on GitHubhttps://github.com/MediaBrowser/MediaBrowser/issues/289#issuecomment-19218570 .

Luke Pulverenti

gcw07 commented 11 years ago

Is there a task to rebuild the library or is this something manual?

LukePulverenti commented 11 years ago

for now it' manual. you need to stop the server and delete the library db file.

On Mon, Jun 10, 2013 at 2:58 PM, Grant notifications@github.com wrote:

Is there a task to rebuild the library or is this something manual?

— Reply to this email directly or view it on GitHubhttps://github.com/MediaBrowser/MediaBrowser/issues/289#issuecomment-19218923 .

Luke Pulverenti

gcw07 commented 11 years ago

That works too. Just wasn't sure. Might be nice later down the line to have a way to do it from the dashboard, but I'm sure doing it while the server is running is a lot more complicated.

gcw07 commented 11 years ago

Actually, what do we delete. There are now some other similiar named files in the data folder

library.db library.db-shm library.db-wal

LukePulverenti commented 11 years ago

all three

On Mon, Jun 10, 2013 at 3:03 PM, Grant notifications@github.com wrote:

Actually, what do we delete. There are now some other similiar named files in the data folder

library.db library.db-shm library.db-wal

— Reply to this email directly or view it on GitHubhttps://github.com/MediaBrowser/MediaBrowser/issues/289#issuecomment-19219260 .

Luke Pulverenti