search

MediaBrowser / Emby

Emby Server is a personal media server with apps on just about every device.
https://emby.media
GNU General Public License v2.0
3.99k stars 792 forks source link

Account with "no access to manage" can still manage some things. #316

Closed swhitmore closed 11 years ago

swhitmore commented 11 years ago

Not sure if this has been brought up, but I added a guest account with no access to manage the server. It looks like they still have access to change some things e.g. scheduled tasks, their own password (not sure if this is needed or not), parental rating etc.

ebr11 commented 11 years ago

I might have created the Parental Rating bug trying to eliminate the condition where the admin user cannot set a max rating...

ebr11 commented 11 years ago

I fixed the part I screwed up but how did you ever get there? If I go into the dashboard from a non-admin user all I get is the dashboard main page and no left side tool menu...

swhitmore commented 11 years ago

Clicked on the profile icon and selected "View Profile". From there I could change stuff.

From: Eric Reedmailto:notifications@github.com Sent: ‎31/‎05/‎2013 2:07 AM To: MediaBrowser/MediaBrowsermailto:MediaBrowser@noreply.github.com Cc: Scott Whitmoremailto:scott.whitmore@live.com.au Subject: Re: [MediaBrowser] Account with "no access to manage" can still manage some things. (#316)

I fixed the part I screwed up but how did you ever get there? If I go into the dashboard from a non-admin user all I get is the dashboard main page and no left side tool menu...

Reply to this email directly or view it on GitHub: https://github.com/MediaBrowser/MediaBrowser/issues/316#issuecomment-18697370

LukePulverenti commented 11 years ago

I just did a teamviewer session with someone who couldn't figure out why library items were missing after they applied parental controls to the admin account, so i think today's change to not allow that is a good thing.

ebr11 commented 11 years ago

I still think you need to be able to allow a max rating on an admin account. People have always stumbled themselves with PC and not realizing why things weren't there. There really isn't a good reason to deny the ability to limit the library with parental control just because one is an admin.

ebr11 commented 11 years ago

It is the blasted "Block Unrated" option that is the big problem here. Now you see why I didn't want to implement it in the first place. Created these issues in MB2 all the time.

I am going to turn it off by default and let the people who really want it turn it on.

LukePulverenti commented 11 years ago

@swhitmore Please re-test on the latest build that has Ebr's changes.

swhitmore commented 11 years ago

Cool cool. The ability to change the Parental Rating is gone, but the account can still access Scheduled Tasks via "Manage Scheduled Tasks". image