MediaBrowser / MediaBrowser.Classic

Emby for Windows Media Center
http://emby.media
55 stars 21 forks source link

Recent Unwatched doesn't rebuild after something is watched #24

Closed CBers closed 11 years ago

CBers commented 11 years ago

MBC does not reflect WATCHED status unless restarted.

TV episodes are only removed from the UNPLAYED RAL if I exit and restart MBC.

MB2 does it straight away, but MBC seems to needs to be restarted to get WATCHED status updates.

ebr11 commented 11 years ago

Your first statement isn't really true is it? My items are marked watched immediately after playing. The recent list just may not be updated to reflect watched status.

CBers commented 11 years ago

OK, but shouldn't they be one and the same ??

ebr11 commented 11 years ago

Yes, but this is a report of a problem so I'm trying to get at what the actual problem is.

CBers commented 11 years ago

When I watch a video, past the max resume mark of 95%, I assume that the video is WATCHED.

What is not happening, is that the WATCHED video is not removed from the UNPLAYED list.

I assumed, wrongly by the sounds of it, that WATCHED and PLAYED are the same thing.

LukePulverenti commented 11 years ago

they are the same, we've just had to dumb down the term from watched to played in mb3 in order to accommodate music. but screens geared towards video can use watched.

On Mon, May 13, 2013 at 4:31 PM, CBers notifications@github.com wrote:

When I watch a video, past the max resume mark of 95%, I assume that the video is WATCHED.

What is not happening, is that the WATCHED video is not removed from the UNPLAYED list.

I assumed, wrongly by the sounds of it, that WATCHED and PLAYED are the same thing.

— Reply to this email directly or view it on GitHubhttps://github.com/MediaBrowser/MediaBrowser.Classic/issues/24#issuecomment-17838536 .

Luke Pulverenti

DGMayor commented 11 years ago

What CBers is trying to say is that the RAL isn't being rebuilt after a show is watched or added. I brought this up a while ago and Ebr said it wasn't implemented yet.

ebr11 commented 11 years ago

Yep and I changed the name of this topic to reflect that.

CBers, Played and Watched are the same. What I was trying to clarify is that the items, in the library are being marked as watched/played properly (if you turn on watched indicators, they behave as you would expect). The only part that isn't working is the recently added unwatched list. Those are two separate pieces of logic within the program even though, logically, the are the same thing to the user.

CBers commented 11 years ago

Yes, watched status seems to be working, but the UNPLAYED list is not updated immediately after watching, I have to exit and re-enter MBC to get the effect.

DGMayor commented 11 years ago

RAL updated after watching The Daily show this evening. Not yet updating when new items are added though.

Spoke too soon. Second show I watched didn't update the RAL.

ebr11 commented 11 years ago

Spoke too soon. Second show I watched didn't update the RAL.

Did you watch it to completion? IOW - is the show marked as watched in the other views?

DGMayor commented 11 years ago

To completion and then deleted it. I'm watching something else now that won't be deleted. Will keep you posted.

ebr11 commented 11 years ago

Not yet updating when new items are added though.

Please put this in a new issue with the exact method you are testing.

DGMayor commented 11 years ago

Just completed an episode of Mad Men..not marked as watched within MBC. MB Server shows it watched.

ebr11 commented 11 years ago

Can I please see the MBC log from that session?

DGMayor commented 11 years ago

https://dl.dropboxusercontent.com/u/45741371/MBClassic-1452013e98e923bf7634b48bdb594544e57decf.log

ebr11 commented 11 years ago

Everything looks good there. When you went out and came back in, did the item show as watched?

DGMayor commented 11 years ago

Yes

CBers commented 11 years ago

Seems to be working OK for me. They are being removed from UNPLAYED list.

DGMayor commented 11 years ago

It worked the first show I watched, but subsequent shows didn't remove from the unplayed list.

CBers commented 11 years ago

I watched 2 shows, and found 3 others in the UNPLAYED list that I knew I'd watched elsewhere (another MBC HTPC), so I played them and zipped through to the end and they were removed from the list.

ebr11 commented 11 years ago

Okay, originally, you said the Mad Men episode "wasn't marked as watched". By that, did you mean it didn't get removed from the list or it didn't show as watched in the library...? Again, these are two different pieces of logic so I need to understand exactly what the problem is.

DGMayor commented 11 years ago

It wasn't removed from the list (still showed 3 to watch after we watched the first of those three). So I drilled down into the show and it was showing 3 episodes as unwatched, including the one we just finished. On my laptop I loaded up the web client and there it was listed as watched. I exited MBC and re-entered, and it was now showing as watched.

CBers commented 11 years ago

I've just checked the MB3 Dashboard, and the shows I WATCHED this morning aren't marked as WATCHED.

I'm using DEFAULT theme - you're using Chocolate aren't you DGMayor ??

ebr11 commented 11 years ago

They are showing watched in MBC but not the dash?

DGMayor commented 11 years ago

See for me it was watched in dash, but not MBC after we watched Mad Men.

CBers commented 11 years ago

Yes, my UNPLAYED list is upto date with what I have watched.

Curiously, I have just started MBC on a 2nd HTPC and it's the same !!

Is it theme related ?? How does MBC tell MB3 Server that something is watched ??

EDIT: Just noticed in Dashboard that 2 episodes that I watched this morning are marked as WATCHED (RED EYE) but they still have NEW tagged on them.

This may have updated as I have just restarted PC so a library scan was performed ??

ebr11 commented 11 years ago

I'm not sure how the dash is updating so let's just concentrate on the MBC stuff in this topic. CBers, so that I understand, you are saying all appears to be working in MBC including between machines, correct?

CBers commented 11 years ago

Yes, it appears to be.

Just started a 3rd HTPC running MBC and it shows the same as the other 2.

DGMayor commented 11 years ago

so I'm wondering if this has anything to do with the favorites?

I have Madmen favorited. I watched it tonight through favorites. If I drill down after I watch the episode within the favorites, it shows watched. If I go to my TV collection and drill down, it doesn't show watched there. web client shows it watched however, and the count on the Favorites RAL hasn't changed (after about 5 minutes so far)

ebr11 commented 11 years ago

Aha. Yes, that's it. Thanks.

DGMayor commented 11 years ago

sweet! :+1:

DGMayor commented 11 years ago

Status on this one? I know you said to wait until you redid the RAL logic, and from posts on the tracker it sounds like you have.

That said, watched Doctor Who tonight, and it didn't remove from the Unwatched RAL (didn't delete it, just watched it).

If you haven't gotten to this yet, no worries, but wanted to mention it just in case.

ebr11 commented 11 years ago

This always appears to work for me. Where did you watch it from?

DGMayor commented 11 years ago

Watched from the RAL. I watch pretty much everything directly from the RAL.

CBers commented 11 years ago

I'm also seeing the same as DGMayor - If I watch something from the UNPLAYED RAL, it is not removed when the video ends.

This was working fine until the last, or last but one, release of MBC.

If I exit MBC and re-enter, the shows are missing from the RAL as expected.

ebr11 commented 11 years ago

Status?

DGMayor commented 11 years ago

Nothing has changed. I watch a show and / or delete it, it's still on the RAL. If a show is added, it doesn't appear. If I cycle through the RAL settings (Unwatched / added / watched) they will remove / appear as they should have.

DGMayor commented 11 years ago

Just watched a movie, and it did disappear from RAL. (first movie I've tried). So far the TV shows haven't. In fact, even though the movie is no longer on the RAL: Unwatched, the two tv shows I watched (and deleted) prior are still there.

DGMayor commented 11 years ago

A trailer just removed from the RAL (first time I think that's ever happened, in in MB2).

I just picked a tv show and basically skipped my way through it and it did not remove from the RAL (didn't delete). It is showing as watched in the web client and if i cycle through the RAL settings it does go away.

It seems to be just TV shows that aren't updating..at least for me.

CBers commented 11 years ago

I concur with DGMayor.

I haven't tried the "cycle through the RAL settings", but if I exit and restart MBC the RAL is updated.

ebr11 commented 11 years ago

Please update with .31.

ebr11 commented 11 years ago

Anyone.... Beuller?

DGMayor commented 11 years ago

watching something right now - won't delete after to make sure it reports properly.

ebr11 commented 11 years ago

Did you back up all the way to EHS? The item won't disappear out from under you if you are within the RAL but it should go away once you go back up to the top. This is kindof by design so that you don't end up with nowhere to go.

DGMayor commented 11 years ago

Seems to be working. So you're saying that if you have a single episode or two single episodes, if you hit play on them from the RAL, when it's over and it drops you back to the RAL, they won't vanish. I thought they did in 2.6, but maybe I'm remembering wrong.

ebr11 commented 11 years ago

I'm not positive what happens with 2.6 in that instance but that is how I've designed it in MBC. My reasoning is two-fold:

  1. It would be weird after playing something to either come back to an empty container or to be sent all the way back to the top. and
  2. When I'm in this workflow, I like to see the items I've watched in this session still there. When they disappear right away, I'm never exactly sure if I'm looking at the right next item.
DGMayor commented 11 years ago

Gotcha. Yeah we consume all our media through MB, so every night we'd sit down and depending on what shows we had to watch, they would be staring at us. As we'd watch them they'd disappear one by one until we were done. I'm going to miss that.

ebr11 commented 11 years ago

They will still disappear if you go back to the EHS. If there is enough of an outcry for it to be different I may look at changing it.

DGMayor commented 11 years ago

I know it's closed, but now I'm wondering if my issue wasn't supremacy. The actions I was describing works perfectly fine in Supremacy for Trailers...hit play on an item while on the RAL and when the item finishes and returns you to the RAL, that item is no longer listed since it's watched. I'm guessing there's some hiccups in his coding for TV shows since that's where we kept seeing the problems between this and adding/deleting items.