search

MediaBrowser / SocketHttpListener

A standalone HttpListener with support for SSL, WebSockets and Mono
MIT License
42 stars 14 forks source link

Websocket test for large messages #2

Closed jabbera closed 9 years ago

jabbera commented 9 years ago

Per the following post it appears that messages were being truncated by the websocket client or server. This pull adds unit tests for http[s] normal websocket communications and one large message test. The large message test passed out of the box. After investigation it turns out that downgrading from WebSocket4Net 0.11 to 0.10 causes the issue to occur. The api client was already upgraded to 0.11 in this commit on 12-23. Assuming it's been released to nuget already this issue should be resolved.

To reproduce the failure use the package manager console on the test project and run:

Install-Package WebSocket4Net -Version 0.10

comment out dispose in the test as thiswas not added till 0.11. You should see the test fail.

I assume this is the commit that resolved the issue. I'm too lazy to bisect.

LukePulverenti commented 9 years ago

great stuff, thanks!

jabbera commented 9 years ago

No problem. I'll leave it to you to comment back to the poster on the forums.

ebr11 commented 9 years ago

Yes, awesome. Did you test this on a Windows 7 server?

LukePulverenti commented 9 years ago

It doesn't matter anymore. there's no more difference between win 7 and 8.

jabbera commented 9 years ago

Just for completeness I did. Windows 8 and I don't get along so well.