search

MediaBrowser / trakt

Trakt plugin for Emby
MIT License
20 stars 16 forks source link

Allow plugin to work when behind a reverse proxy #19

Closed jackw closed 1 year ago

jackw commented 3 years ago

As per this thread in the forums CSP prevents inline javascript from running when Emby is behind a reverse proxy. This PR aims to solve this by moving the JS into a separate file. I've also taken the opportunity to remove as much of jQuery as possible from this plugin.

LukePulverenti commented 3 years ago

The code looks good.

jackw commented 3 years ago

I'm taking this out of draft. I'm not all that familiar with the emby ecosystem but have given it a test against a dummy server (using media stubs) and a dummy trakt account and it appears to be working when marking as watched and when running scheduled task. Would appreciate a more knowledgeable pair of eyes!

jackw commented 1 year ago

@LukePulverenti I'm trying to tie up open PRs of mine and stumbled upon this. I've move away from Emby for the time being but feel free to merge or close this as you wish. ✌️

LukePulverenti commented 1 year ago

Thanks !