Adding support for Athena

MediaMath / lambda-cron

LambdaCron - serverless cron tool

Apache License 2.0

25 stars 4 forks source link

Adding support for Athena #27

Closed sean-garvey closed 7 years ago

sean-garvey commented 7 years ago

Added Athena Task and tests
Edited typos in README.md

javibravo commented 7 years ago

@sean-garvey,

Code looks good. Still missing something:

Documentation. You should update README with the new type of task.
Update LambdaCron policy. LambdaCron needs permissions on Athena to be able to execute queries: https://github.com/MediaMath/lambda-cron/blob/master/lambda_cron/template.cfn.yml#L63

sean-garvey commented 7 years ago

Javier and I have discussed whether or not we should validate AWS API parameters (as the API may evolve over time) and have decided to table to the topic for now.

javibravo commented 7 years ago

Tested in AWS, all ok. Feature ready to merge!

@sean-garvey , One more thing we forgot, we need to update the diagram in the README. To update it:

Load lambda-cron-diagram.xml in https://www.draw.io/ (you don't need to sign up).
Update diagram.
Export diagram as PNG and save XML file.
Add both of them to the repo.