Made changes for gaol_type not included

MediaMath / t1-python

Python SDK for MediaMath Platform APIs

https://developer.mediamath.com/

Apache License 2.0

18 stars 28 forks source link

Made changes for gaol_type not included #169

Closed palghadmalavinash closed 6 years ago

palghadmalavinash commented 6 years ago

Changes made to add new goal_types and additional parameters that are required for this goal_types.

FodT commented 6 years ago

Hi @palghadmalavinash - thanks for this PR! I've made a few comments on the code. Also, the travis build is failing on unit tests - I can't merge until the issues are resolved :)

palghadmalavinash commented 6 years ago

Hi @FodT, Thanks for the comments, Have made the changes accordingly. Can you please have look. Thanks and Regards. Avinash

swparekh commented 6 years ago

Hi @FodT if the changes look good can we merge this today?