search

MediaMath / t1-python

Python SDK for MediaMath Platform APIs
https://developer.mediamath.com/
Apache License 2.0
18 stars 28 forks source link

fix connection.py and add some more offline tests #44

Closed FodT closed 9 years ago

pswaminathan commented 9 years ago

Integration tests failed here on creative_approvals. I don't think that is a problem with the code, though, but rather a problem of environment. That creative now has four creative approval entities, not three. We can't rely on a given creative having a fixed number of creative approval entities.

Further, speaking to Melissa about it, creative approvals are deleted when the creative stops running (as in, when the creative approvals are no longer relevant). Thus, we can't even rely on them being there. As it's out of the scope of this PR, I just changed test.py to look for >=3. But that should be fixed.

FodT commented 9 years ago

Ideally any AC/integration tests that run against the actual DB should be creating nonce data - not sure if we can do that in prod, though.