search

MediaMath / t1-python

Python SDK for MediaMath Platform APIs
https://developer.mediamath.com/
Apache License 2.0
18 stars 28 forks source link

Rudimentary support for margin api. #66

Closed ellisbenjamin closed 8 years ago

ellisbenjamin commented 8 years ago

Added margin.py models.

Altered T1.get to always return generator for margin child objects. Kinda hacky? Making all child objects return generators fixes https://github.com/MediaMath/t1-python/issues/47 , but this is outside my realm so that's for you guys to discuss I guess.

pswaminathan commented 8 years ago

Hey Ben—this is failing PEP8 checks. All commits go through PEP8 checks as part of CI, so take a look at the Travis output at https://travis-ci.org/MediaMath/t1-python/builds/104975578.

Additionally, I don't want to have specific exceptions for margin pulled in. If there are specific XML tags for it for it (like there are for permissions and certain targets), then the parser can be different. But don't want any specific URL-checking, etc.

Understand you have an app you're trying to build with this, and this is likely not going to be merged in time for you to use a release here. You can point your pip requirements file to your branch though to work on your app: take a look at the pip docs for details.

ellisbenjamin commented 8 years ago

Hey Prasanna,

Thanks for the detailed response! Since we need this for the app we're building, I'll just have pip install it from my forked repo for the time being and then revise when support for the margin API comes through officially. LMK if there's anything I can do to help out!