Open Helcostr opened 3 years ago
Unfortunately that isn't going to be a viable option since the CSS2 system colors weren't well-supported, and are now deprecated. Can do a basic dark and light theme, however.
i thinj the goal is to translate system colors into selecting light dark, not necessarily translating system colors type for type
On Fri, Dec 4, 2020 at 9:45 PM Michael Little notifications@github.com wrote:
Unfortunately that isn't going to be a viable option since the CSS2 system colors weren't well-supported, and are now deprecated. Can do a basic dark and light theme, however.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MediaWikiAGE/MAGE/issues/28#issuecomment-739130915, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADSSUNLKJRF3ZAX2VSVLS5TSTHCI7ANCNFSM4UOESTVQ .
Does #60 accomplish the goal of the issue? And if so, can the issue be closed?
This seems to be a partial fix? Is it properly hooking into the OS's color theme?
Well, at the very least, if MAGE is started when the OS theme is light or dark, MAGE chooses (its own) light or dark colors respectively. So while it doesn't use system-defined colors for its interface, the "lightness mode" is that chosen for the OS.
Potentially pull a default theme from the current OS color theme?