search

MediaWikiAGE / MAGE

MediaWiki Automated Graphical Editor. Mostly meant to be a replacement for AutoWikiBrowser (AWB).
MIT License
7 stars 7 forks source link

Wikis on the same domain with not-Fandom-like different paths don't get saved correctly #67

Closed AttemptToCallNil closed 3 years ago

AttemptToCallNil commented 3 years ago

Try saving a "wiki farm" with these wikis:

https://cat.cat/Main Page
https://cat.cat/de/Main Page
https://cat.cat/ru/Main Page

The current "get-wikiname-from-url" algorithm assumes that wiki farms either use separate subdomains, or Fandom-like paths that start with /[two letters]/wiki. In other cases (same domain, other kind of paths), the login form will only save the last entry and overwrite the rest with it.

I don't think there can be a universal conflict resolution algorithm for this problem, so I guess adding indices like cat.cat [2], cat.cat [3] is the way to go, at least for now.

Helcostr commented 3 years ago

Uh oh XD

I think instead of object based keys... it should be array based. That way overwriting won't happen.

IIRC, I had an array based system last time 🤔 .

AttemptToCallNil commented 3 years ago

I already fixed this issue in my coming PR.