search

Medialist / medialist-app

Mission: Increase PR team productivity 10x
0 stars 1 forks source link

Double @ fix #246

Closed richsilv closed 8 years ago

richsilv commented 8 years ago

Requires #244 Fixes #181

Note that a more permanent (i.e. better) solution will become possible once we've implemented a solution for #161 and we're updating the contact's details as a whole rather than line-by-line (in which case we have to work out which line it is and whether we should be stripping the @).

olizilla commented 8 years ago

@richsilv pls merge master

richsilv commented 8 years ago

Done @olizilla

olizilla commented 8 years ago

@alanshaw did you add a magic bean for stripping@ if present in the csv import pr? Would be good to reuse that logic here.

alanshaw commented 8 years ago

I did - https://github.com/Medialist/medialist-app/tree/master/packages/twitter-screen-name

Use twitterScreenName(str) to get back the screen name without @. If you give it a twitter URL it'll do the same.

richsilv commented 8 years ago

Updated to use the @alanshaw module