Medialist / medialist-app

Mission: Increase PR team productivity 10x
0 stars 1 forks source link

input color being set to light grey, ignoring value of @input-color #266

Closed olizilla closed 8 years ago

olizilla commented 8 years ago

All our inputs are rendering in a light grey text colour. It's nice but a bit too light.

There is a bootstrap var for setting the input color called: @input-color The puzzle: setting it makes no difference.

Turns out, in our compiled css we're getting this kind of thing:

.form-control {
  display: block;
  width: 100%;
  height: 37px;
  padding: 6px 16px;
  color: hotpink;
...
  transition: border-color ease-in-out .15s, box-shadow ease-in-out .15s;
  color: #9e9e9e;
}

Where my test value of hotpink is being overridden in the same selector to a nice mid-grey.

It turns out that bootstrap calls a mixin called placeholder at the end of the .form-control less definition... https://github.com/Medialist/medialist-app/blob/35417b0de947bb710d32aab7ec5607e46befce49/client/lib/bootstrap/bootstrap-raw.import.less#L3538

And it turns out we're overriding the definition of .placeholder to always return a nice mid grey... https://github.com/Medialist/medialist-app/blob/35417b0de947bb710d32aab7ec5607e46befce49/client/templates/contact/details.import.less#L154

olizilla commented 8 years ago

Fixed.