Medialist / medialist-app2

:newspaper: Make your PR team smarter and faster with media lists that capture intelligence, cut admin hours and keep campaigns in sync.
http://medialist.io/
1 stars 1 forks source link

Coverage smart embeds (contact activity view, campaign activity view) #210

Closed OllyGilbert closed 7 years ago

OllyGilbert commented 7 years ago

contact-profile-vicki-owen-15 2x

embebed

olizilla commented 7 years ago

@OllyGilbert do we need to handle the case where the user enters multiple urls?

OllyGilbert commented 7 years ago

@olizilla good point. In this instance let's show a smart embed for the first url given, but display all the urls in the user comment

OllyGilbert commented 7 years ago

This is how facebook does it:

screen shot 2017-03-02 at 13 10 23
olizilla commented 7 years ago

@OllyGilbert The properties

will be displayed if available. Some or all of them may not be found in the source document.

For example http://www.wired.co.uk/article/nintendo-switch-no-save-data-transfer has no article:published_time property.

OllyGilbert commented 7 years ago

@olizilla understood!

olizilla commented 7 years ago

This is implemented now. To confirm

When a smart embed is displayed in a coverage post in an activity feed, the url concerned is hidden from the user's comment is not implemented, but rather it is left "facebook style" and the urls are in the copy as well embeding the preview of the first one.

Auto linking the urls is a separate issue that should be tackled as part of making the inputs support basic markdown, for bold, italic and autolinking of urls

olizilla commented 7 years ago

Fixed in #369

OllyGilbert commented 7 years ago

@olizilla can we remove the loading indicator from the log feedback/coverage input field so that user's don't hang around if the smart embed is never going to arrive