search

MedicOneSystems / livewire-datatables

Advanced datatables using Laravel, Livewire, Tailwind CSS and Alpine JS
https://livewire-datatables.com/
MIT License
1.19k stars 258 forks source link

Add support to set default date filter start and end to support other Date/DateTime types. #450

Closed shaneburrell closed 2 years ago

shaneburrell commented 2 years ago

The default hard set in code does not work with smalldatetime in MS SQL. This makes it configurable.

thyseus commented 2 years ago

Hey, @shaneburrell just saw you started a fork. I think i am the last active Maintainer of this package and i would merge your feature now if you want, so no fork is necessary ?

shaneburrell commented 2 years ago
shaneburrell commented 2 years ago

The package updates and PR's were quite a ways behind so I needed to fork as it was holding up use in projects. If development picks back up here I would rather not maintain my own fork and package but for now it was really my only option.

thyseus commented 2 years ago

This looks very good to me. I will merge this tomorrow when i am in office and i will release a new minor version then ! No need to fork, i try to look more often into the pull requests now.

shaneburrell commented 2 years ago

Note that since posting the PR I've done quite a bit in my master branch. You may want to just peel that one change.

thyseus commented 2 years ago

You mean, i should choose "squash and merge" to keep the git history clean, i assume.

Done so.