MedicOneSystems / livewire-datatables

Advanced datatables using Laravel, Livewire, Tailwind CSS and Alpine JS
https://livewire-datatables.com/
MIT License
1.19k stars 258 forks source link

Bugfix checkboxes behavior when search or filters are active #522

Closed renardudezert closed 1 year ago

renardudezert commented 1 year ago

If the search or filter is active, we must display the count of checked rows only for "visible" items (results of search or filtered results). Therefore, the toggleSelectAll() method must also check or uncheck all "visible" items when the search or filters are active. See the gif below in order to view the correct behavior (what this PR brings) bugfix-checkboxes-beahavior-livewire-datatables

thyseus commented 1 year ago

@renardudezert thanks a lot for your work, will merge once you fixed that minor typo !

renardudezert commented 1 year ago

You're welcome. It is a good project, the contributions are deserved.