Fix missing grammar parameter in getValue() for laravel 10.

MedicOneSystems / livewire-datatables

Advanced datatables using Laravel, Livewire, Tailwind CSS and Alpine JS

https://livewire-datatables.com/

MIT License

1.19k stars 259 forks source link

Fix missing grammar parameter in getValue() for laravel 10. #591

Closed Nowocyn closed 11 months ago

Nowocyn commented 1 year ago

Using version_compare to maintain downward compatibility.

Fixing bug:

Too few arguments to function Illuminate\Database\Query\Expression::getValue(), 0 passed in /var/www/html/vendor/mediconesystems/livewire-datatables/src/Http/Livewire/LivewireDatatable.php on line 417 and exactly 1 expected

Based on the issue and fix of @daniftinca #584

Nowocyn commented 1 year ago

Found this bug already fixed in the branch livewire-v3. So this PR is not really necessary.

What is the actual status of the upgrade from livewire v2 to v3?

guywarner commented 1 year ago

This one save my butt, thank you!

code23-barna commented 11 months ago

Sorry @Nowocyn but I do think it is a important fix, as currently the package doesn't work with Laravel 10, so it is a breaking issue. I think it should be fixed regardless the livewire version, it has to work on livewire 2

Nowocyn commented 11 months ago

Yeah I know. That's the reason there are so many forks with the fix already in it. But it hasn't got merged yet. Can someone merge it?