search

Medical-Event-Data-Standard / meds

Schema definitions and Python types for Medical Event Data Standard, a standard for medical event data such as EHR and claims data
Apache License 2.0
38 stars 3 forks source link

Added new constants for fields, types, and directories. All directory constants are relative to the `MEDS_ROOT` dir. #48

Closed mmcdermott closed 2 months ago

EthanSteinberg commented 2 months ago

@mmcdermott This looks good to me. I made a small number of changes though:

  1. I added os.path.join to the paths so we can support Windows (which uses \ to separate paths)

  2. I merged the prediction_type_dtype and the time_dtype as they must both be the same in order for anything to work.

  3. I added a comment about why we are using "us" time resolution.

  4. I moved the paths to the top of the definitions to make them more obvious to spot.

If all those changes look good, feel free to merge!