Tiny boot() refactor - Githubissues

Medium / matador

an MVC framework for Node

http://medium.github.io/matador

Other

604 stars 49 forks source link

Closed vinibaggio closed 11 years ago

vinibaggio commented 11 years ago

Hello anyone,

Please review the following commits I made in branch 'vinny-boot-refactor'.

c7f36e9bfa0fbb31dc1d9e81c9f4db4653bcdaa5 (2013-09-06 11:17:47 -0300) Remove session from boot so secret is not hardcoded

851406f9d1ed3496334435fb3eb0e6d946d2e5b9 (2013-09-06 11:17:29 -0300) Calling afterboot callback after boot is done but before router

R=anyone

nicks commented 11 years ago

lgtm

vinibaggio commented 11 years ago

@nicks app already had EventEmitter methods so I just had to emit the new event. Feels much cleaner, thanks.

nicks commented 11 years ago

lgtm