search

Medium / matador

an MVC framework for Node
http://medium.github.io/matador
Other
604 stars 49 forks source link

Remove filters and controller middleware. Make boot sequence compatible with medium. #148

Closed dpup closed 10 years ago

dpup commented 10 years ago

Hello @nicks, @vinibaggio,

I'm on a mission to make Matador more closely resemble how we actually use it in Medium. I'm going to gut a bunch of un-used and confusing functionality and then start to migrate a lot of what is currently in medium over to matador.

This first change moves the initialization sequence closer to something that medium can use and removes the notion of controller specific middleware and filters, both of which I think are confusing and error prone.

Please review the following commits I made in branch 'dpup-yaks'.

5d5be2a6a87d697eefda9c7694405709ba0dc93a (2014-04-03 18:58:58 -0700) Remove filters and controller middleware. Make boot sequence compatible with medium.

R=@nicks R=@vinibaggio

dpup commented 10 years ago

Merged with don's change

nicks commented 10 years ago

lgtm!

dpup commented 10 years ago

I think this should be a 2.0.0-alpha1, there are two options I'd like a 2nd opinion on.

  1. Don't push to NPM but create a tag with the version until its ready.
  2. Continue pushing alpha releases to NPM
nicks commented 10 years ago

it depends on your use case.

if you're still testing it, then i prefer link/LOCAL_MODULES instead of pushing to npm

if you want a real repository to use it, then i prefer pushing to npm instead of using github URLs in package.json files

On Fri, Apr 4, 2014 at 10:43 AM, Daniel Pupius notifications@github.comwrote:

I think this should be a 2.0.0-alpha1, there are two options I'd like a 2nd opinion on.

  1. Don't push to NPM but create a tag with the version until its ready.
  2. Continue pushing alpha releases to NPM

Reply to this email directly or view it on GitHubhttps://github.com/Medium/matador/pull/148#issuecomment-39591722 .

dpup commented 10 years ago

yeah, I'm thinking for actual use by medium. I'll push to npm with an 2.0.0-alpha.1 version.

-- Dan

On Fri, Apr 4, 2014 at 10:49 AM, Nick Santos notifications@github.comwrote:

it depends on your use case.

if you're still testing it, then i prefer link/LOCAL_MODULES instead of pushing to npm

if you want a real repository to use it, then i prefer pushing to npm instead of using github URLs in package.json files

On Fri, Apr 4, 2014 at 10:43 AM, Daniel Pupius <notifications@github.com

wrote:

I think this should be a 2.0.0-alpha1, there are two options I'd like a 2nd opinion on.

  1. Don't push to NPM but create a tag with the version until its ready.
  2. Continue pushing alpha releases to NPM

Reply to this email directly or view it on GitHub< https://github.com/Medium/matador/pull/148#issuecomment-39591722>

.

Reply to this email directly or view it on GitHubhttps://github.com/Medium/matador/pull/148#issuecomment-39592320 .