fix matador functional tests on node 0.12

Medium / matador

an MVC framework for Node

http://medium.github.io/matador

Other

604 stars 49 forks source link

fix matador functional tests on node 0.12 #163

Closed nicks closed 9 years ago

nicks commented 9 years ago

Hello @vinibaggio,

Please review the following commits I made in branch 'nick-node12'.

c68f20ef7ee0049773fa04406af3efe5fc46c680 (2015-02-17 16:01:14 -0500) fix matador functional tests on node 0.12

R=@vinibaggio

vinibaggio commented 9 years ago

oh whoa. Does it make sense for the test runner to only listen on ipv4 to make it easier? Just curious, this makes sense. LGTM

nicks commented 9 years ago

ya, i was surprised at first too, but on reflection i think the move to listen on both by default is right and Good For The Web. maybe someday we'll get rid of ipv4 completely!

vinibaggio commented 9 years ago

haha I like the Good For The Web argument. Thanks