Support permanent redirects

Medium / matador

an MVC framework for Node

http://medium.github.io/matador

Other

604 stars 49 forks source link

Closed majelbstoat closed 9 years ago

majelbstoat commented 9 years ago

Hello @nicks, @dpup,

Please review the following commits I made in branch 'jamie-permanent-redirect-support'.

901de2ae4e3de9aa14728070b708096abc696a0f (2015-03-13 13:50:13 -0700) Support permanent redirects

R=@nicks R=@dpup

nicks commented 9 years ago

the boolean argument seems...surprising. should it just be a separate method?

majelbstoat commented 9 years ago

I mean, I could. Just seemed like a different flavour of redirect. Strong preference?

nicks commented 9 years ago

ya, it seems pretty likely that this will bite us if we do it this way, due to the .then(res.redirect.bind(res, location)) problem

majelbstoat commented 9 years ago

oh, good point. yup, will change.

majelbstoat commented 9 years ago

Changes made, ready for a second pass.

nicks commented 9 years ago

lgtm