remove extraneous call to decodeURI

Medium / matador

an MVC framework for Node

http://medium.github.io/matador

Other

604 stars 49 forks source link

remove extraneous call to decodeURI #172

Closed kylewm closed 8 years ago

kylewm commented 8 years ago

Hello @adrianlee44, @majelbstoat, @nicks,

Please review the following commits I made in branch 'kylewm/over-decoding'.

3868ba6b90c9f455bdbc15b6c473808505113978 (2016-06-23 13:28:30 -0700) remove extraneous call to decodeURI

calling decodeURI twice makes it difficult to pass in encoded special characters intact
add functional tests for over-decoding paths matching *

R=@adrianlee44 R=@majelbstoat R=@nicks

nicks commented 8 years ago

i don't understand why this changes the behavior of non-wildcards? i thought that was working correctly

nicks commented 8 years ago

(though maybe i'm wrong and misunderstood the original report)

nicks commented 8 years ago

lgtm code seems fine tho

kylewm commented 8 years ago

@nicks Good point. You're right, the original bug report was against wildcards, but named parameters seemed to be handled the same way. It made sense to me to consolidate them rather than treat * as a special case.