search

Medium / matador

an MVC framework for Node
http://medium.github.io/matador
Other
604 stars 49 forks source link

Emit events for redirects #173

Closed kylehg closed 7 years ago

kylehg commented 7 years ago

Hello @vinibaggio, @nicks,

Please review the following commits I made in branch 'kyle-redirects'.

83aba3b93f17591c54fe2599d5f97e84346a4456 (2016-09-28 22:11:40 -0700) Emit events for redirects

R=@vinibaggio R=@nicks

kylehg commented 7 years ago

I couldn't see a good reason to keep the -alpha tag around? It's not like things aren't stable and we're already post-1.0

nicks commented 7 years ago

can you elaborate a bit on the motivation for this change?

events can sometimes become the poor man's GOTO. i'd like to be more deliberate about what the response event api should be, rather than sticking random new events on it.

i wonder if they should both fire a 'redirect' event instead of having a separate event?