search

Medium / matador

an MVC framework for Node
http://medium.github.io/matador
Other
604 stars 41 forks source link

Adding PORT environmental variable support. #78

Closed HelloGrayson closed 12 years ago

HelloGrayson commented 12 years ago

Useful for deployment and on PaaS services like Heroku.

For example, Heroku uses a different port for each deploy. Luckily, the port number is stored in an environmental variable called PORT.

https://devcenter.heroku.com/articles/nodejs

azulus commented 12 years ago

lgtm

HelloGrayson commented 12 years ago

Good deal - this makes a default Matador installation work on Heroku/Nodejitsu immediately.

dpup commented 12 years ago

I'll merge, but do you want to bump the minor version first?

dpup commented 12 years ago

Actually, forget that. Jeremy pointed out it'd be better for us to bump the version before pushing to npm.

dpup commented 12 years ago

You can find your changes in 1.1.7-beta (http://search.npmjs.org/#/matador)

Thanks for the patch.

HelloGrayson commented 12 years ago

nice - sorry about squeezing the favicon in here that should have been in another PR.

dpup commented 12 years ago

It's cool. Seemed harmless.