Make strings in views i18n compat

Medium / medium-wordpress-plugin

The official WordPress plugin for cross-posting to Medium.

https://medium.com

Apache License 2.0

210 stars 40 forks source link

Make strings in views i18n compat #20

Closed frankiejarrett closed 8 years ago

frankiejarrett commented 8 years ago

This PR makes all strings inside the views i18n compatible in the proper WordPress way.

I was careful to properly escape variables for output that existed in/around i18n strings, and I wrapped HTML within i18n strings separately for full RTL support.

majelbstoat commented 8 years ago

Thanks for doing this before I got round to it, much appreciated. Would you believe I wrote l10n and i18n plugins back in the day? ;)

Let me know if you want your name added to a contributors section on the Readme!

majelbstoat commented 8 years ago

(Remember also to squash commits when done.)

General rules:

1 commit per PR.
1 "fix" per commit.
A commit message that describes the overall fix.

majelbstoat commented 8 years ago

Resolved by: https://github.com/Medium/medium-wordpress-plugin/pull/30 . Thanks for the pointers, @fjarrett.