search

Medium / medium-wordpress-plugin

The official WordPress plugin for cross-posting to Medium.
https://medium.com
Apache License 2.0
210 stars 40 forks source link

Add more logging and improve failure case of claims API #54

Closed kylehg closed 8 years ago

kylehg commented 8 years ago

Hello @mikkot,

Please review the following commits I made in branch 'kyle-logging'.

ab31f0010f6221800d2ccb4011a2e15236b15e18 (2015-12-06 17:52:51 -0800) Add more logging and improve failure case of claims API

R=@mikkot

majelbstoat commented 8 years ago

I don't think this is right, as claims will not be created for regularly cross-posted posts. That's why the claim creation was inside cross_post.

mikkot commented 8 years ago

Yeah we literally just realized this with Kyle and are changing it so claims get made in the original spot, but with try/catch around it.

majelbstoat commented 8 years ago

Sounds good. Can you cc me on all plugin prs? ;)

On Mon, Dec 7, 2015 at 6:32 PM Mikko T. notifications@github.com wrote:

Yeah we literally just realized this with Kyle and are changing it so claims get made in the original spot, but with try/catch around it.

— Reply to this email directly or view it on GitHub https://github.com/Medium/medium-wordpress-plugin/pull/54#issuecomment-162616512 .