Medium / phantomjs

NPM wrapper for installing phantomjs
Other
1.42k stars 435 forks source link

"node install.js" should be "nodejs install.js" #180

Closed yuntan closed 10 years ago

yuntan commented 10 years ago

I'm an linux user.
I tried to install phantomjs via npm install, but an error occurred during installation.

> phantomjs@1.9.7-8 install /home/yuntan/Workspace/Co-mender/mori-github/node_modules/karma-phantomjs-launcher/node_modules/phantomjs
> node install.js

npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian

npm ERR! weird error 1

I think that installer want to use /usr/bin/nodejs but there is node command in /usr/sbin/, so can't execute nodejs.

I think line 38 in package.json should be nodejs install.js (https://github.com/Medium/phantomjs/blob/master/package.json#L38 )

Kubuntu 14.04 64bit

nicks commented 10 years ago

see: https://github.com/joyent/node/wiki/Installing-Node.js-via-package-manager#ubuntu-mint-elementary-os

TLDR: it's expected that Ubuntu users should symlink /usr/bin/node to /usr/bin/nodejs, or most node programs wont' work