search

Medium / phantomjs

NPM wrapper for installing phantomjs
Other
1.43k stars 435 forks source link

bundle dependencies #585

Closed rmg closed 8 years ago

rmg commented 8 years ago

Bundling the dependencies ensures that they are always present when npm runs a package's lifecycle scripts. This is necessary to get any sort of consistency in behaviour when using dependencies in install scripts because the installation order in npm@2 is non-deterministic and that is the version of npm that ships with the current LTS releases of Node.

This should address #581, #580, #578, #553, #584

May also help with #302, #556, #555, which aren't clear what their root causes are due to lack of detail.

rmg commented 8 years ago

As a PoC/test, this was published as bundled-phantomjs-prebuilt which seemed to clear up the problem for me in all the environments I tested in that were previously failing (#580 - node 0.10, 0.12, 4 on Linux).

amir20 commented 8 years ago

Works for me as well. I was able to install with Docker.

nicks commented 8 years ago

sure, happy to try it and see if it helps

rmg commented 8 years ago

@nicks thanks for the quick turnaround, really appreciate it!