Closed cognitom closed 8 years ago
cool! i like this!
can you fill out a CLA real quick? https://github.com/Medium/opensource/blob/master/sign-cla.md
@nicks sure! Will do.
@nicks the logic is wrapped by try
block now 😄
Could you have a look?
Updated: README.md, too.
thanks!
exec()
is just a shortcut ofchildProcess.spawn()
run()
returns a promise, and waits until PhantomJS get readyTo use
phantomjs-prebuilt
with WebDriver, we needed to detect when PhantomJS gets ready. But that was little bit messy, like this:By this PR, it'll be easy and readable:
If you like this PR, I'd like to add some README text, too. Thanks.