search

Medium / phantomjs

NPM wrapper for installing phantomjs
Other
1.43k stars 435 forks source link

remove bundledDependencies. #603

Closed nicks closed 8 years ago

nicks commented 8 years ago

Hello @nicks,

Please review the following commits I made in branch 'nicks/bundling'.

076b9595c3b8a5c700ebf8ebc3c1a324974e1ea4 (2016-08-12 08:34:40 -0400) remove bundledDependencies. This option appears to be non-portable: a package published on one OS / NPM version with bundledDependencies breaks in cryptic ways on other OSes and NPM versions.

R=@nicks

NicolasPelletier commented 8 years ago

This appears to have re-opened closed issues. See #607.