Medium / phantomjs

NPM wrapper for installing phantomjs
Other
1.43k stars 435 forks source link

Prevent replacement of global.Promise in node v4 #625

Closed marcbachmann closed 7 years ago

marcbachmann commented 7 years ago

Currently by requiring phantomjs-prebuilt, the original Promise is replaced by the es6-promise module. This has been fixed in es6-promise v4.0.3 and we should incorporate it.

How to reproduce the current behavior?

$ nvm use 4
$ node
> console.log(Promise)
[Function: Promise]

> require('phantomjs-prebuilt')

> console.log(Promise)
{ [Function: lib$es6$promise$promise$$Promise]
  all: [Function: lib$es6$promise$promise$all$$all],
  race: [Function: lib$es6$promise$promise$race$$race],
  resolve: [Function: lib$es6$promise$promise$resolve$$resolve],
  reject: [Function: lib$es6$promise$promise$reject$$reject],
  _setScheduler: [Function: lib$es6$promise$asap$$setScheduler],
  _setAsap: [Function: lib$es6$promise$asap$$setAsap],
  _asap: [Function: asap] }
nicks commented 7 years ago

thanks!

nicks commented 7 years ago

published as 2.1.13