search

Medium / phantomjs

NPM wrapper for installing phantomjs
Other
1.42k stars 435 forks source link

Upgrade some deps #653

Closed nicks closed 7 years ago

nicks commented 7 years ago

Hello @nicks,

Please review the following commits I made in branch 'nicks/bump'.

379d3ae752ab1f704f21fb052de46743aeee18d6 (2016-12-09 12:01:16 -0500) Upgrade some deps

R=@nicks

jerry98225 commented 7 years ago

It breaks our build process after you upgrade some deps. We use Jenkins and it fails with the following message: [exec] npm ERR! phantomjs-prebuilt@2.1.14 install: node install.js [exec] npm ERR! Exit status 8 [exec] npm ERR! [exec] npm ERR! Failed at the phantomjs-prebuilt@2.1.14 install script 'node install.js'. [exec] npm ERR! This is most likely a problem with the phantomjs-prebuilt package, [exec] npm ERR! not with npm itself. [exec] npm ERR! Tell the author that this fails on your system: [exec] npm ERR! node install.js

It worked fine before this request get merged.

We can't just simply downgrade the version because it's another dependency that requires 2.1.14.